guluo2016 commented on code in PR #8276:
URL: https://github.com/apache/hbase/pull/8276#discussion_r3420306037
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java:
##########
@@ -377,7 +379,7 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
String fName = MobUtils.getMobFileName(c);
// Added to support migration
try {
- mobCell = mobStore.resolve(c, true, false).getCell();
+ mobCell = mobStore.resolve(c, cacheMobBlocksOnCompaction,
false).getCell();
Review Comment:
LGTM for this changes，Thanks!
With the help of IDEA inspections, I noted an additional issue:
`mobStore.resolve()` would return `MobCell` object, and `MobCell implements
Closeable`, so, should we explicitly close it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
