Apache9 commented on PR #8362: URL: https://github.com/apache/hbase/pull/8362#issuecomment-4719467532
> > In [HBASE-30200](https://issues.apache.org/jira/browse/HBASE-30200), we have already banned all junit4 dependencies. Since there are still junit4 assert references in hadoop mini cluster code, I introduced dummy Assert class to delegate all calls to junit5 Assertions. And all the method in this class has RestrictedApi annotation to disable usage in HBase code base. > > I think this is enough? > > Hi, @Apache9, the extra import ban seems still useful as an earlier and clearer guardrail, it fails the build when new JUnit4 imports are added, see #8340 and #8361, WDYT > > <img alt="image" width="1650" height="380" src="https://private-user-images.githubusercontent.com/42756849/608596156-b8fb8009-0630-4717-939e-0ae98233df22.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODE2MTc5MTgsIm5iZiI6MTc4MTYxNzYxOCwicGF0aCI6Ii80Mjc1Njg0OS82MDg1OTYxNTYtYjhmYjgwMDktMDYzMC00NzE3LTkzOWUtMGFlOTgyMzNkZjIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNjE2VDEzNDY1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzZTcxOWFjZjU0NTMwNTk4M2JhZTg4N2JjMzJjMTcwNGQwNmI5NmYzYjI1M2Q2YTRhMjk0ZTg2OGMzMjBiNTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.jrqVaY3F4Ma0hsoLDEl4jzR8ja3CS07te7JkqVhDpBk";> In #8361 , the branch compile is already failing right? You should see an error in pre commit check when adding the calls. But yeah. this does not fail local builds if you do not enable error prone, with this PR in the local build will also fail too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/42756849/608596156-b8fb8009-0630-4717-939e-0ae98233df22.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODE2MTc5MTgsIm5iZiI6MTc4MTYxNzYxOCwicGF0aCI6Ii80Mjc1Njg0OS82MDg1OTYxNTYtYjhmYjgwMDktMDYzMC00NzE3LTkzOWUtMGFlOTgyMzNkZjIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNjE2VDEzNDY1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzZTcxOWFjZjU0NTMwNTk4M2JhZTg4N2JjMzJjMTcwNGQwNmI5NmYzYjI1M2Q2YTRhMjk0ZTg2OGMzMjBiNTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.jrqVaY3F4Ma0hsoLDEl4jzR8ja3CS07te7JkqVhDpBk"](https://private-user-images.githubusercontent.com/42756849/608596156-b8fb8009-0630-4717-939e-0ae98233df22.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODE2MTc5MTgsIm5iZiI6MTc4MTYxNzYxOCwicGF0aCI6Ii80Mjc1Njg0OS82MDg1OTYxNTYtYjhmYjgwMDktMDYzMC00NzE3LTkzOWUtMGFlOTgyMzNkZjIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNjE2VDEzNDY1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzZTcxOWFjZjU0NTMwNTk4M2JhZTg4N2JjMzJjMTcwNGQwNmI5NmYzYjI1M2Q2YTRhMjk0ZTg2OGMzMjBiNTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.jrqVaY3F4Ma0hsoLDEl4jzR8ja3CS07te7JkqVhDpBk"){kind=link}