VladRodionov commented on code in PR #8384:
URL: https://github.com/apache/hbase/pull/8384#discussion_r3456209288
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java:
##########
@@ -190,20 +191,56 @@ public class CacheConfig implements
PropagatingConfigurationObserver {
* @param conf hbase configuration
*/
public CacheConfig(Configuration conf) {
- this(conf, null);
+ this(conf, (CacheAccessService) null);
}
+ /**
+ * Create a cache configuration using the specified configuration object and
block cache. Only use
+ * in tests
+ * @param conf hbase configuration
+ * @param blockCache block cache to use for this configuration
+ */
public CacheConfig(Configuration conf, BlockCache blockCache) {
Review Comment:
This is the test only constructor, which mirrors (Configuration, BlockCache)
counterpart. The old one will be removed. Removing (Configuration conf,
CacheAccessService service) will require some extensive refactoring of a
CacheConfig class. Not sure if CacheConfig refactoring will be a part of this
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
