liuxiaocs7 commented on code in PR #8404:
URL: https://github.com/apache/hbase/pull/8404#discussion_r3464996785
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestBulkLoadReplication.java:
##########
@@ -162,13 +162,19 @@ private static void startThirdCluster() throws Exception {
}
@BeforeEach
- public void resetBulkLoadCount() throws Exception {
- // removing the peer and adding again causing the previously completed
bulk load jobs getting
- // submitted again, so here we override the setUpBase and tearDownBase to
not adding/removing
- // peers between each tests, we will add peers in beforeAll
+ @Override
+ public void setUpBase() throws Exception {
+ // Removing the peer and adding it back causes previously completed
bulk-load jobs to be
+ // resubmitted. Override setUpBase/tearDownBase so we do not add/remove
peers between tests;
+ // peers are added once in @BeforeAll.
BULK_LOADS_COUNT = new AtomicInteger(0);
}
+ @Override
+ public void tearDownBase() throws Exception {
+ // do not remove PEER_ID2
+ }
Review Comment:
We’d better add an `@AfterEach` annotation to maintain consistency here,
even though it’s equivalent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
