[ https://issues.apache.org/jira/browse/HBASE-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449410#comment-13449410 ]
Ted Yu commented on HBASE-6476: ------------------------------- >From N: bq. I've done it just before this patch after a comment from Stack, but after some thinking I don't think it's a good idea: in tests you want the real time. See https://reviews.apache.org/r/6521/diff/1/?file=137550#file137550line52 > Replace all occurrances of System.currentTimeMillis() with EnvironmentEdge > equivalent > ------------------------------------------------------------------------------------- > > Key: HBASE-6476 > URL: https://issues.apache.org/jira/browse/HBASE-6476 > Project: HBase > Issue Type: Bug > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Priority: Minor > Fix For: 0.96.0 > > Attachments: 6476.txt, 6476-v2.txt, 6476-v2.txt > > > There are still some areas where System.currentTimeMillis() is used in HBase. > In order to make all parts of the code base testable and (potentially) to be > able to configure HBase's notion of time, this should be generally be > replaced with EnvironmentEdgeManager.currentTimeMillis(). > How hard would it be to add a maven task that checks for that, so we do not > introduce System.currentTimeMillis back in the future? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira