taklwu commented on PR #8413: URL: https://github.com/apache/hbase/pull/8413#issuecomment-4803824659
> > Copilot's concern is valid. > > Just noticed that you've already applied the fix. Still reusing stuff in [HBaseHostnameVerifier](https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/HBaseHostnameVerifier.java#L134) is worth to consider. HBaseHostnameVerifier is a private class in hbase-common, your comment for reusing the those functions e.g. parseIpAddress would require moving/refactoring those functions into a public class e.g. Strings that HRegionServer can access. I will give a try, but if that refactoring is not what you expected, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
