wchevreuil commented on code in PR #156:
URL: https://github.com/apache/hbase-connectors/pull/156#discussion_r3481715317
##########
hbase-connectors-assembly/src/main/assembly/hbase-connectors-bin.xml:
##########
@@ -34,12 +34,11 @@
<useAllReactorProjects>true</useAllReactorProjects>
<excludes>
<exclude>org.apache.hbase.connectors.spark:hbase-spark-it</exclude>
- <!-- Not yet packaged when assembly runs (reactor lists spark4 after
this module).
- Exclude until dist layout includes Spark 4; -->
+ <!-- Spark 4 line: not part of the default binary layout yet. -->
<exclude>org.apache.hbase.connectors.spark:hbase-spark4</exclude>
- <!-- Keep the Scala binary suffix in sync with scala.binary.version in
spark4/pom.xml;
- hbase-spark-pushdown artifactId is version-suffixed. -->
-
<exclude>org.apache.hbase.connectors.spark:hbase-spark-pushdown_${scala.binary.version}</exclude>
+ <!-- Internal pushdown libraries (pulled transitively by hbase-spark /
hbase-spark4).
+ ArtifactIds are Scala-suffixed; assembly descriptors do not
interpolate ${scala.binary.version}. -->
+
<exclude>org.apache.hbase.connectors.spark:hbase-spark_${spark4.scala.binary.version}</exclude>
</excludes>
Review Comment:
not an issue, we still build the final binary on spark3 only. We'll revisit
it later when the final spark4 integration is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
