PDavid commented on code in PR #8453:
URL: https://github.com/apache/hbase/pull/8453#discussion_r3551384103
##########
pom.xml:
##########
@@ -1876,6 +1875,25 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-all</artifactId>
+ <version>${netty4.version}</version>
Review Comment:
Can I ask why do we need to add `netty-all` to `<dependencyManagement>`?
As I see we only import `netty-bom` (line 1874) in `<dependencyManagement>`
- we do NOT declare `netty-all` as a direct dependency. The comment at line
877-884 explicitly explains that `netty-all` historically caused classpath
conflicts when mixed with individual netty modules, and the project solved this
by pinning versions via the BOM.
Also HBase itself uses shaded netty via `hbase-thirdparty` repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
