taklwu commented on code in PR #8575:
URL: https://github.com/apache/hbase/pull/8575#discussion_r3877569775
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/cache/SingleEngineTopology.java:
##########
Review Comment:
will this `SingleEngineTopology` use with `SingleTierTopology` ? or how does
it work in the upcoming/next JIRA?
mainly I found no usage about this `SingleEngineTopology`
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/cache/DefaultHBaseCachePlacementAdmissionPolicy.java:
##########
@@ -60,7 +63,7 @@ public TierDecision selectTier(BlockCacheKey cacheKey,
Cacheable block, CacheWri
* L2 when both tiers are available, but falls back to any available tier
rather than rejecting
* placement.
*/
- if (topologyView.getType() == CacheTopologyType.SINGLE) {
+ if (topologyView.getType() == CacheTopologyType.SINGLE_TIER) {
return TierDecision.single(CacheTier.SINGLE);
Review Comment:
I'm wondered if `CacheTier.SINGLE` should be removed and only keep L1 and
L2? but let me know if my understanding is incorrect.
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/cache/CacheAccessServiceTestFactory.java:
##########
Review Comment:
it seems this line of comment is no longer valid that we're using
`TopologyBackedCacheAccessServices`, can you update the comment of `blockCache`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
