shoemoney commented on PR #8573: URL: https://github.com/apache/hbase/pull/8573#issuecomment-5499951519
Working on getting the JIRA filed and linked. Also flagging something CI caught: implementing the simplified `getCompactBoundariesForMajor` (always return `[MIN_VALUE, cutOffTimestamp]`) as suggested breaks 5 existing tests: - `TestCustomCellTieredCompactionPolicy#testGetCompactBoundariesForMajorNoOld/OneOnEachSide/OneCrossing` assert specific boundary-list sizes (1/3/3) from the old min/max-from-tag logic. - `TestCustomCellTieredCompactor#testCustomCellTieredCompactor` and `#testCustomCellTieredCompactorWithRowKeyDateTieringValue` explicitly assert (with an inline comment) that the first major compaction of untagged files produces exactly 1 HFile, since "without the min/max values available in the file info... CustomCellDateTieredCompactionPolicy has no means to calculate the proper boundaries." Always offering the cutoff boundary changes that: the very first compaction now produces 2 files. That's arguably a nice side effect (it also fixes the "first compaction can't split" limitation), but it's a real behavior change beyond the reported bug. Want me to update those 5 tests/comments to match the new intended behavior, or would you rather I do a narrower fix that only handles the mixed tagged/untagged case without changing first-compaction semantics? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
