liuxiaocs7 commented on code in PR #8628:
URL: https://github.com/apache/hbase/pull/8628#discussion_r3961873540
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java:
##########
@@ -160,6 +161,12 @@ private boolean isValidRegion(RegionInfo hri) {
if (hri.isOffline() && (hri.isSplit() || hri.isSplitParent())) {
return false;
}
+ // The mob region is a dummy region used only to organise mob files under
mobdir. It has no
+ // region directory under the table dir to open, and holds no rows. See
HBASE-30365 and
+ // HBASE-30368.
Review Comment:
Hi, @junegunn, thanks for catching this and for verifying the full scan.
You're right—the “holds no rows” wording is inaccurate. I've removed it from
both `TableSnapshotScanner` and `TableSnapshotInputFormatImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
