Huginn-kio opened a new pull request, #8670:
URL: https://github.com/apache/hbase/pull/8670

   ## HBASE-30397
   
   ### Summary
   
   Correct the warning emitted when 
`ReplicationSourceShipper.clearWALEntryBatch` is interrupted while waiting for 
the shipper and reader threads to stop. This completes the remaining branch of 
the logging correction tracked in 
[HBASE-30397](https://issues.apache.org/jira/browse/HBASE-30397).
   
   ### Root cause
   
   The `InterruptedException` branch in 
`hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java`
 passes the exception as the final argument to a message with three 
placeholders. Because the final argument is a `Throwable`, the final 
placeholder is not populated as intended. The timeout branch was addressed by 
[HBASE-29698](https://issues.apache.org/jira/browse/HBASE-29698), but this 
interrupted branch remains.
   
   ### Fix
   
   - Format the interrupted exception with `e.toString()` for the final 
placeholder.
   - Preserve the peer ID and thread name in the warning message.
   
   ### Testing
   
   - Logging-only change; no test run.
   - `git diff --check` — pass.
   - Targeted Maven Checkstyle could not run because the available Java runtime 
is Java 8 while the resolved Checkstyle dependency requires Java 17.
   
   ### Compatibility
   
   - Public API impact: none
   - Config impact: none
   - Persisted format impact: none
   - Wire format impact: none
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to