[ 
https://issues.apache.org/jira/browse/HBASE-30403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18117905#comment-18117905
 ] 

Hudson commented on HBASE-30403:
--------------------------------

Results for branch branch-2.6
        [build #519 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/519/]:
 (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/519/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/519/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/519/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/519/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/519/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk21 hadoop3 checks{color}
-- For more information [see jdk21 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/519/JDK21_20Nightly_20Build_20Report_20_28Hadoop3_29/]


> CustomDateTieredCompactionPolicy#getCompactBoundariesForMajor drops the 
> cutOffTimestamp boundary when files lack CUSTOM_TIERING_TIME_RANGE
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-30403
>                 URL: https://issues.apache.org/jira/browse/HBASE-30403
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 3.0.0, 2.6.7
>            Reporter: Jeremy Schoemaker
>            Assignee: Jeremy Schoemaker
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.7.0, 3.0.1, 2.6.8
>
>
> getCompactBoundariesForMajor derives the major-compaction boundaries from the 
> CUSTOM_TIERING_TIME_RANGE file-info tag of every file in filesToCompact. 
> Files written before custom tiering was enabled (or by any writer that does 
> not set the tag) contribute nothing, so with a mixed or untagged set the 
> min/max traversal produces a boundary list that never contains the 
> cutOffTimestamp split. The major compaction then writes a single tier instead 
> of separating hot and cold cells.
> Fix (PR https://github.com/apache/hbase/pull/8573): always return 
> [Long.MIN_VALUE, cutOffTimestamp] without traversing filesToCompact. This is 
> safe because CustomTieringMultiFileWriter#append already buckets each cell by 
> these boundaries and only commits a file for a tier that actually received 
> data, so an empty tier never produces an empty HFile. The five tests in 
> TestCustomCellTieredCompactionPolicy and TestCustomCellTieredCompactor that 
> asserted boundary counts derived from the old tag traversal are updated to 
> the new intended behavior in the same PR.
> Review thread with wchevreuil on the PR agreed the simplified approach on 
> 2026-08-26; this ticket is filed at his request so the change can be merged.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to