Sigma-Ma commented on code in PR #8587:
URL: https://github.com/apache/hbase/pull/8587#discussion_r4249613967
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:
##########
@@ -636,6 +635,7 @@ protected List<RegionPlan> balanceTable(TableName tableName,
currentCost / sumMultiplier, functionCost(), computedMaxSteps);
final String initFunctionTotalCosts = totalCostsPerFunc();
+ cluster.setStopRequestedAt(EnvironmentEdgeManager.currentTime() +
maxRunningTime);
Review Comment:
> I think this changes the behavior of the timeout? Is it valid?
I've revised the patch to preserve the original timeout behavior and removed
the deadline-ordering test.
The fixture now uses four hosts, four RegionServers per host and three
replicas. The existing host-level replica-placement assertions are retained.
The same-host test passed 10 consecutive runs with failure reruns disabled.
The related balancer and replica tests also passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
