wchevreuil commented on code in PR #169: URL: https://github.com/apache/hbase-connectors/pull/169#discussion_r4336682700
########## spark4/hbase-spark4/src/main/scala/org/apache/hadoop/hbase/spark/SchemaConverters.scala: ########## Review Comment: Added a UNION case that resolves nullable unions (e.g., ["null", "int"]) by stripping the null branch and delegating to the inner type. Multi-branch unions (more than one non-null type) throw UnsupportedOperationException with a clear message. Also improved the default case from generic Exception to UnsupportedOperationException. Yes, read side always calls AvroSerdes.deserialize which returns GenericRecord, which doesn't handle top-level primitives. This is the same behaviour as in spark3 module, not introduced by this PR. Fixing deserialize to handle primitive Avro types would be a broader change best addressed in a follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
