[
https://issues.apache.org/jira/browse/HBASE-30491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-30491:
-----------------------------------
Labels: pull-request-available (was: )
> Run TestShadedTestingUtilJarContents in nightly shadedjars checks
> -----------------------------------------------------------------
>
> Key: HBASE-30491
> URL: https://issues.apache.org/jira/browse/HBASE-30491
> Project: HBase
> Issue Type: Test
> Components: build, test
> Reporter: mazhengxuan
> Assignee: mazhengxuan
> Priority: Minor
> Labels: pull-request-available
>
> PR #8789 fixes the clean test failure by skipping
> TestShadedTestingUtilJarContents when HBaseTestingUtil is loaded from a class
> directory.
> As discussed in that PR, nightly builds should still verify that
> hbase-shaded-testing-util does not bundle JUnit libraries. The shadedjars
> stage currently skips tests and does not include
> hbase-shaded-testing-util-tester, so this check is not run there.
> Include the tester module in the shadedjars build and run
> TestShadedTestingUtilJarContents against the packaged shaded JAR. Keep the
> existing JAR contents assertions and the directory-based skip for clean test.
> Validation:
> - clean test succeeds, with the JAR contents check skipped when classes are
> loaded from directories.
> - shadedjars executes the check against the packaged JAR with no skips.
> - Bundling a prohibited JUnit class or Platform service declaration causes
> the check to fail.
> Related discussion:
> https://github.com/apache/hbase/pull/8789#issuecomment-6281275197
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
