[
https://issues.apache.org/jira/browse/HBASE-30534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-30534.
-------------------------------
Fix Version/s: 4.0.0-alpha-1
2.7.0
3.1.0
3.0.1
2.6.8
2.5.17
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to all active branches.
Thanks [~liuxiaocs] for reviewing!
> The filterUser logic should not be placed in PermissionStorage
> --------------------------------------------------------------
>
> Key: HBASE-30534
> URL: https://issues.apache.org/jira/browse/HBASE-30534
> Project: HBase
> Issue Type: Improvement
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-1, 2.7.0, 3.1.0, 3.0.1, 2.6.8, 2.5.17
>
>
> HBase's ACL model supports group, which is stored as
> {noformat}
> @GROUP_NAME
> {noformat}
> in acl table.
> And when checking whether a user has proper permissions or getting the
> permissions for a user, we need to expand the group to a list of users. The
> filterUser parameter is used in this case.
> But PermissionStorage is designed as class to communicate with the acl table,
> so putting the filterUser logic in it, will mess up the logic for
> implementation grant/revoke.
> So I prefer we do a refactoring, to leave PermissionStorage as simple as
> possible, and move the filterUser logic to upper layer, which could make the
> code easier to understand.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)