[ 
https://issues.apache.org/jira/browse/HBASE-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454683#comment-13454683
 ] 

Lars Hofhansl commented on HBASE-6769:
--------------------------------------

+1 on 0.94 patch as well.

This comment is weird, as it refers to a non existing exception.
{code}
+              // Don't send a FailedSanityCheckException as older clients will 
not know about
+              // that class being a subclass of DoNotRetryIOException
+              // and will retry mutations that will never succeed.
{code}

Don't post a new patch :) ... I'll change the comment on commit:
{code}
// Use generic DoNotRetryIOException so that older clients know how to deal 
with it.
{code}

                
> HRS.multi eats NoSuchColumnFamilyException since HBASE-5021
> -----------------------------------------------------------
>
>                 Key: HBASE-6769
>                 URL: https://issues.apache.org/jira/browse/HBASE-6769
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.0, 0.94.1
>            Reporter: Jean-Daniel Cryans
>            Assignee: Elliott Clark
>            Priority: Critical
>             Fix For: 0.96.0, 0.94.2
>
>         Attachments: HBASE-6769-0.94-0.patch, HBASE-6769-0.94-1.patch, 
> HBASE-6769-0.patch
>
>
> I think this is a pretty major usability regression, since HBASE-5021 this is 
> what you get in the client when using a wrong family:
> {noformat}
> 2012-09-11 09:45:29,634 WARN 
> org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 1 
> action: DoNotRetryIOException: 1 time, servers with issues: sfor3s44:10304, 
>       at 
> org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.processBatchCallback(HConnectionManager.java:1601)
>       at 
> org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.processBatch(HConnectionManager.java:1377)
>       at org.apache.hadoop.hbase.client.HTable.flushCommits(HTable.java:916)
>       at org.apache.hadoop.hbase.client.HTable.doPut(HTable.java:772)
>       at org.apache.hadoop.hbase.client.HTable.put(HTable.java:747)
> {noformat}
> Then you have to log on the server to understand what failed.
> Since everything is now a multi call, even single puts in the shell fail like 
> this.
> This is present since 0.94.0
> Assigning to Elliott because he asked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to