[ 
https://issues.apache.org/jira/browse/HBASE-6409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455341#comment-13455341
 ] 

Andrew Wang commented on HBASE-6409:
------------------------------------

Hi Elliot, sorry about the delay on getting back to you.

I don't think there's an issue with sharing an executor. IIRC, findbugs 
complained since it didn't correctly pick up on synchronizing on the parent 
MutableQuantiles, but it's fine.

The datanode and namenode still seem to shutdown correctly even though the 
threads aren't daemonized. Making them daemonized probably won't hurt though, 
so also LGTM.
                
> Create histogram class for metrics 2
> ------------------------------------
>
>                 Key: HBASE-6409
>                 URL: https://issues.apache.org/jira/browse/HBASE-6409
>             Project: HBase
>          Issue Type: Sub-task
>          Components: metrics
>    Affects Versions: 0.96.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Blocker
>         Attachments: HBASE-6409-0.patch, HBASE-6409-1.patch, 
> HBASE-6409-2.patch, HBASE-6409-3.patch, HBASE-6409-4.patch
>
>
> Create the replacement for MetricsHistogram and PersistantTimeVaryingRate 
> classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to