[ 
https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455451#comment-13455451
 ] 

stack commented on HBASE-6776:
------------------------------

bq. For opened region of disabled table, it should be added to online region 
list, and then closed. We should not just ignore them.

So, I see you add all to online regions in your patch.  If we do this inside in 
the rebuild of user regions, where do we do the close you suggest above?

I see you do this: getZKTable().setDisablingTable(tableName);

What is going on here?  The table was Disabled but you are setting the set back 
to Disabling because you came across a region that is still open?

bq. For opened region of enabling table, it should be added to online region 
list, so that we don't have to assign it again. Without adding it to online 
region list, it could be double assigned when assign it again later.

This seems right.
                
> Opened region of disabled/enabling table is not added to online region list
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-6776
>                 URL: https://issues.apache.org/jira/browse/HBASE-6776
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: trunk-6776.patch
>
>
> For opened region of disabled table, it should be added to online region 
> list, and then closed.  We should not just ignore them.
> For opened region of enabling table, it should be added to online region 
> list, so that we don't have to assign it again.  Without adding it to online 
> region list, it could be double assigned when assign it again later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to