[
https://issues.apache.org/jira/browse/HBASE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457437#comment-13457437
]
Devaraj Das commented on HBASE-6758:
------------------------------------
bq. I see, all that double-negation (eg !fileNotInUse) confused me
Sorry about that. I'll see if I can change it to single negation :-)
bq. So in layman's terms, your patch short circuits all the checks to change
the current path if we know for sure that the file we are replicating from is
being written to. The side effect is that we won't quit the current file unless
it has aged right?
Yes ..
bq. FWIW that might not be totally true, at least in 0.94 HLog.postLogRoll is
called before HLog.cleanupCurrentWriter which does issue a sync().
I don't get this, JD. Could you please clarify a bit more? Given the fact that
the currentPath would be updated only after the call to cleanupCurrentWriter, I
don't see a difference in the behavior between 0.92 and 0.94... (maybe I am
missing something though).
> [replication] The replication-executor should make sure the file that it is
> replicating is closed before declaring success on that file
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6758
> URL: https://issues.apache.org/jira/browse/HBASE-6758
> Project: HBase
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Attachments: 6758-1-0.92.patch
>
>
> I have seen cases where the replication-executor would lose data to replicate
> since the file hasn't been closed yet. Upon closing, the new data becomes
> visible. Before that happens the ZK node shouldn't be deleted in
> ReplicationSourceManager.logPositionAndCleanOldLogs. Changes need to be made
> in ReplicationSource.processEndOfFile as well (currentPath related).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
