[ https://issues.apache.org/jira/browse/HBASE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462457#comment-13462457 ]
Lars Hofhansl commented on HBASE-6868: -------------------------------------- Cool... The only strange spot left is here: http://hbase.apache.org/xref/org/apache/hadoop/hbase/io/hfile/HFileBlock.html#1473 We're setting useHBaseChecksum to true in the absence of any information from HFileSystem. As far as I can tell this only triggered by tests, so I think we're good. Will commit tomorrow unless there are any objections. Agree on the testing, I will add this to the testing spreadsheet. I think I will sink the current 0.94.2 RC for this. > Skip checksum is broke; are we double-checksumming by default? > -------------------------------------------------------------- > > Key: HBASE-6868 > URL: https://issues.apache.org/jira/browse/HBASE-6868 > Project: HBase > Issue Type: Bug > Components: HFile, wal > Affects Versions: 0.94.0, 0.94.1 > Reporter: LiuLei > Priority: Blocker > Fix For: 0.94.3, 0.96.0 > > Attachments: 6868-0.96-idea.txt, 6868-0.96-v2.txt, 6868-0.96-v3.txt > > > The HFile contains checksums for decrease the iops, so when Hbase read HFile > , that dont't need to read the checksum from meta file of HDFS. But HLog > file of Hbase don't contain the checksum, so when HBase read the HLog, that > must read checksum from meta file of HDFS. We could add setSkipChecksum per > file to hdfs or we could write checksums into WAL if this skip checksum > facility is enabled -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira