[ 
https://issues.apache.org/jira/browse/HBASE-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463941#comment-13463941
 ] 

nkeywal commented on HBASE-6702:
--------------------------------

I wrote something in "HBASE-6884 Update documentation on unit tests". But I 
mainly suppressed the old stuff, without explaining the listener itself.

About it, we could write:
A specific listener checks a number of resources before and after each tests 
and logs them. These resources are the number of threads, the number of file 
descriptor, ... If the number has increased, it adds a "LEAK?" comment in the 
logs. As you can have an HBase instance running in the background, some threads 
can be deleted/created without any specific action in the test. However, if the 
test does not work as expected, or if the test should not impact these 
resources, it's worth checking these log lines  "hbase.ResourceChecker(157): 
before" and "hbase.ResourceChecker(157): after"
                
> ResourceChecker refinement
> --------------------------
>
>                 Key: HBASE-6702
>                 URL: https://issues.apache.org/jira/browse/HBASE-6702
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Assignee: nkeywal
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 6702.v1.patch, 6702.v4.patch, 6702.v5.patch
>
>
> This was based on some discussion from HBASE-6234.
> The ResourceChecker was added by N. Keywal to help resolve some hadoop qa 
> issues, but has since not be widely utilized. Further, with modularization we 
> have had to drop the ResourceChecker from the tests that are moved into the 
> hbase-common module because bringing the ResourceChecker up to hbase-common 
> would involved bringing all its dependencies (which are quite far reaching).
> The question then is, what should we do with it? Get rid of it? Refactor and 
> resuse? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to