[ 
https://issues.apache.org/jira/browse/HBASE-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464287#comment-13464287
 ] 

Jimmy Xiang commented on HBASE-6611:
------------------------------------

Posted a patch on RB: https://reviews.apache.org/r/7305/.  Please review.

I did some performance testing and found the async zookeeper node offline is 
big performance +, so it is kept.  Without this patch,
it took around 290 seconds to bulk assign 10,339 regions to 4 region servers.  
With this patch, it took around 300 seconds.
However, without async zookeeper node offline, it took around 400 seconds.

As to force close regions, it is not touched and still working as expected.
                
> Forcing region state offline cause double assignment
> ----------------------------------------------------
>
>                 Key: HBASE-6611
>                 URL: https://issues.apache.org/jira/browse/HBASE-6611
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>
> In assigning a region, assignment manager forces the region state offline if 
> it is not. This could cause double assignment, for example, if the region is 
> already assigned and in the Open state, you should not just change it's state 
> to Offline, and assign it again.
> I think this could be the root cause for all double assignments IF the region 
> state is reliable.
> After this loophole is closed, TestHBaseFsck should come up a different way 
> to create some assignment inconsistencies, for example, calling region server 
> to open a region directly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to