[ 
https://issues.apache.org/jira/browse/HBASE-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466306#comment-13466306
 ] 

Lars Hofhansl commented on HBASE-6619:
--------------------------------------

Patch looks good. I like delaying parsing to the actual reading. We're getting 
way too many context switches otherwise (unless I misunderstand the existing 
code).
The only question I have: Why not use an ExecutorService again, instead of the 
manual round robin done by the patch?
                
> Do no unregister and re-register interest ops in RPC
> ----------------------------------------------------
>
>                 Key: HBASE-6619
>                 URL: https://issues.apache.org/jira/browse/HBASE-6619
>             Project: HBase
>          Issue Type: Bug
>          Components: IPC/RPC, Performance
>            Reporter: Karthik Ranganathan
>            Assignee: Michal Gregorczyk
>            Priority: Critical
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: 
> 0001-jira-HBASE-6619-89-fb-Do-no-unregister-and-re-regist.patch
>
>
> While investigating perf of HBase, Michal noticed that we could cut about 
> 5-40% (depending on number of threads) from the total get time in the RPC on 
> the server side if we eliminated re-registering for interest ops.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to