[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466591#comment-13466591
]
stack commented on HBASE-5937:
------------------------------
How is HLogSplitter going to work w/ different implementations? Currently you
punt and refer to FSHLog?
This too seems like an HLog thing rather than something that belongs out in
util:
{code}
HLogUtil.getRegionDirRecoveredEditsDir
{code}
When region server opens, it'll want to ask the HLog implementation how to read
back its edits? Not go to util?
FYI in hbase, like hadoop, we're about two spaces for indent (See HLogMetrics)
Yeah, whats this crazy thing supposed to do? {code} resetLogReaderClass{code}
Factory looks like it needs a get reader for my edits and you pass in the
region whose edits you want?
FYI, next time, you could use Bytes.toBytes in HBase under util to do this:
"HBASE::CACHEFLUSH".getBytes(HConstants.UTF8_ENCODING);
The following from HLogUtil I'd think belong in an implementation:
{code}
validateHLogFilename
getReader // Why this in util and in factory too? .... or, its commented out
along w/ createWriter?
getHLogDirectoryName
getRegionDirRecoveredEditsDir // Can do this later... seems like I ask the
implementation for reader on the edits...
moveAsideBadEditsFile
getSplitEditFilesSorted // Yeah, this would be in the HLog splitting
implementation... or not exposed at all
{code}
No problem if you want to address the above later
Something is up w/ your pom-it in the patch. You are removing its contents.
So, what you want to do? If tests pass and you are fairly sure you have not
done anything to change our wal write speed -- it doesn't look like you have
changed any of that, then if you want to do a part 1 commit and then open new
issue to address outstanding, improving WAL Interface, etc., I'd be +1 on that.
> Refactor HLog into an interface.
> --------------------------------
>
> Key: HBASE-5937
> URL: https://issues.apache.org/jira/browse/HBASE-5937
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: 5937-hlog-with-javadoc.txt, HBASE-5937.patch,
> HBASE-5937.patch, HBASE-5937.patch, HBASE-5937.patch, HBASE-5937.patch,
> org.apache.hadoop.hbase.client.TestMultiParallel-output.txt
>
>
> What the summary says. Create HLog interface. Make current implementation use
> it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
