[ https://issues.apache.org/jira/browse/HBASE-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468223#comment-13468223 ]
Hadoop QA commented on HBASE-6459: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547467/6459v3.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 83 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks org.apache.hadoop.hbase.catalog.TestMetaReaderEditor Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2990//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2990//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2990//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2990//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2990//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2990//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2990//console This message is automatically generated. > improve speed of create table > ----------------------------- > > Key: HBASE-6459 > URL: https://issues.apache.org/jira/browse/HBASE-6459 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.94.0 > Reporter: zhou wenjian > Assignee: Zhou wenjian > Fix For: 0.96.0 > > Attachments: 6459v3.txt, HBASE-6459-90.patch, HBASE-6459-92.patch, > HBASE-6459-94.patch, HBASE-6459-trunk.patch, HBASE-6459-trunk-v2.patch > > > in CreateTableHandler > for (int regionIdx = 0; regionIdx < this.newRegions.length; regionIdx++) { > HRegionInfo newRegion = this.newRegions[regionIdx]; > // 1. Create HRegion > HRegion region = HRegion.createHRegion(newRegion, > this.fileSystemManager.getRootDir(), this.conf, > this.hTableDescriptor, null, false, true); > regionInfos.add(region.getRegionInfo()); > if (regionIdx % batchSize == 0) { > // 2. Insert into META > MetaEditor.addRegionsToMeta(this.catalogTracker, regionInfos); > regionInfos.clear(); > } > // 3. Close the new region to flush to disk. Close log file too. > region.close(); > } > All the region will be create serially. > If we have thousands of regions, that will be a huge cost. > We can improve it by create the region in parallel -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira