[ https://issues.apache.org/jira/browse/HBASE-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477688#comment-13477688 ]
Hadoop QA commented on HBASE-6991: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549444/HBASE-6991_trunk.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 9 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 82 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3060//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3060//console This message is automatically generated. > Escape "\" in Bytes.toStringBinary() and its counterpart Bytes.toBytesBinary() > ------------------------------------------------------------------------------ > > Key: HBASE-6991 > URL: https://issues.apache.org/jira/browse/HBASE-6991 > Project: HBase > Issue Type: Bug > Components: util > Affects Versions: 0.96.0 > Reporter: Aditya Kishore > Assignee: Aditya Kishore > Fix For: 0.96.0 > > Attachments: HBASE-6991_trunk.patch > > > Since "\" is used to escape non-printable character but not treated as > special character in conversion, it could lead to unexpected conversion. > For example, please consider the following code snippet. > {code} > public void testConversion() { > byte[] original = { > '\\', 'x', 'A', 'D' > }; > String stringFromBytes = Bytes.toStringBinary(original); > byte[] converted = Bytes.toBytesBinary(stringFromBytes); > System.out.println("Original: " + Arrays.toString(original)); > System.out.println("Converted: " + Arrays.toString(converted)); > System.out.println("Reversible?: " + (Bytes.compareTo(original, converted) > == 0)); > } > Output: > ------- > Original: [92, 120, 65, 68] > Converted: [-83] > Reversible?: false > {code} > The "\" character needs to be treated as special and must be encoded as a > non-printable character ("\x5C") to avoid any kind of unambiguity during > conversion. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira