[ https://issues.apache.org/jira/browse/HBASE-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477987#comment-13477987 ]
Ted Yu commented on HBASE-6942: ------------------------------- {code} + if (opStatus[i].getOperationStatusCode() != OperationStatusCode.SUCCESS) { + break; + } {code} Should we continue to check status code for the remaining opStatus ? {code} + byte[] versionsDeleted = deleteWithLockArr[i].getFirst().getAttribute( + NO_OF_VERSIOS_TO_DELETE); {code} Typo in the constant name above. {code} + int noOfVersiosToDelete = 0; {code} Typo in variable name above. {code} + return Bytes.hashCode(this.family) + Bytes.hashCode(this.qualifier); {code} Can we come up with better hash code ? Looking at both approaches, I think using delete template gives us flexibility and cleaner code. > Endpoint implementation for bulk delete rows > -------------------------------------------- > > Key: HBASE-6942 > URL: https://issues.apache.org/jira/browse/HBASE-6942 > Project: HBase > Issue Type: Improvement > Components: Coprocessors, Performance > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 0.94.3, 0.96.0 > > Attachments: HBASE-6942_DeleteTemplate.patch, HBASE-6942.patch, > HBASE-6942_V2.patch, HBASE-6942_V3.patch, HBASE-6942_V4.patch, > HBASE-6942_V5.patch, HBASE-6942_V6.patch > > > We can provide an end point implementation for doing a bulk deletion of > rows(based on a scan) at the server side. This can reduce the time taken for > such an operation as right now it need to do a scan to client and issue > delete(s) using rowkeys. > Query like delete from table1 where... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira