[ 
https://issues.apache.org/jira/browse/HBASE-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481649#comment-13481649
 ] 

stack commented on HBASE-6728:
------------------------------

Nit:

Could assign and declare in the one step instead of have it straddle 
constructor:

{code}

+    this.currentSize = new AtomicLong(0);
{code}

Do we have to pollute metrics w/ an actual instance of HRegionServer:

{code}
+  private HRegionServer regionServer;
{code}

Do we have to add new public method on HRegionServer to getResponseQueueSize?

Lets not put this in trunk, not until after hbase-6410 goes in.  It does this 
properly.  Can go into 0.94.
                
> [89-fb] prevent OOM possibility due to per connection responseQueue being 
> unbounded
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6728
>                 URL: https://issues.apache.org/jira/browse/HBASE-6728
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Michal Gregorczyk
>             Fix For: 0.96.0
>
>         Attachments: 6728-trunk.txt
>
>
> The per connection responseQueue is an unbounded queue. The request handler 
> threads today try to send the response in line, but if things start to 
> backup, the response is sent via a per connection responder thread. This 
> intermediate queue, because it has no bounds, can be another source of OOMs.
> [Have not looked at this issue in trunk. So it may or may not be applicable 
> there.]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to