[
https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482938#comment-13482938
]
Hadoop QA commented on HBASE-3925:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12550584/HBASE-3925-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3132//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3132//console
This message is automatically generated.
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the
> default. When using the supplied debug command we only switch the backtrace,
> but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
>
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
>
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
