[ https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483782#comment-13483782 ]
Hadoop QA commented on HBASE-5257: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12550721/HBASE-5257-0.94.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 9 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3141//console This message is automatically generated. > Allow filter to be evaluated after version handling > --------------------------------------------------- > > Key: HBASE-5257 > URL: https://issues.apache.org/jira/browse/HBASE-5257 > Project: HBase > Issue Type: Improvement > Reporter: Lars Hofhansl > Fix For: 0.96.0 > > Attachments: 5257-trunk.txt, HBASE-5257-0.92.txt, HBASE-5257-0.94.txt > > > There are various usecases and filter types where evaluating the filter > before version are handled either do not make sense, or make filter handling > more complicated. > Also see this comment in ScanQueryMatcher: > {code} > /** > * Filters should be checked before checking column trackers. If we do > * otherwise, as was previously being done, ColumnTracker may increment > its > * counter for even that KV which may be discarded later on by Filter. > This > * would lead to incorrect results in certain cases. > */ > {code} > So we had Filters after the column trackers (which do the version checking), > and then moved it. > Should be at the discretion of the Filter. > Could either add a new method to FilterBase (maybe excludeVersions() or > something). Or have a new Filter wrapper (like WhileMatchFilter), that should > only be used as outmost filter and indicates the same (maybe > ExcludeVersionsFilter). > See latest comments on HBASE-5229 for motivation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira