[ 
https://issues.apache.org/jira/browse/HBASE-7039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485386#comment-13485386
 ] 

ramkrishna.s.vasudevan commented on HBASE-7039:
-----------------------------------------------

@Sergery
Thanks for your patch Sergery.
It may be a problem if the changes in HBASE-6012 does not go in.  The problems 
in HBASE-6012 are sure to happen.
Also if the RS goes down, just before the openRPC is sent to the RS, if we get 
an exception we may retry.
This retry and the SSH flow may now overlap.
This will lead to abnormal abort of RS or master.  
Have you tested this patch by continuously balancing and killing and restarting 
RS? That will tell you many of the issues.
Actually the bulk assign infact does not take care of some things which normal 
assign() does.  
                
> Port HBASE-5914 Bulk assign regions in the process of ServerShutdownHandler 
> (and bugfix part of HBASE-6012) to 0.94
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7039
>                 URL: https://issues.apache.org/jira/browse/HBASE-7039
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 0.94.2
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7039-squashed.patch, test-am.log, test.log, 
> test-rerun.log
>
>
> This is a major feature, so please -1 if you think it's too dangerous to port.
> However, it's also a perf improvement for recovery.
> The 2nd thing that HBASE-6012 addresses cannot be included without a breaking 
> interface change (HRegionInterface openRegions doesn't return region states 
> which are relied upon by the trunk code that is using protocol buffers API); 
> or a non-breaking interface change with version-checking hackery to take 
> advantage of it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to