[ https://issues.apache.org/jira/browse/HBASE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485513#comment-13485513 ]
Lars Hofhansl commented on HBASE-6846: -------------------------------------- I attributed Lucian in the commit. Would need to add him as contributor. I have not seen other patches from him, yet. I'm fine either way. :) > BitComparator bug - ArrayIndexOutOfBoundsException > -------------------------------------------------- > > Key: HBASE-6846 > URL: https://issues.apache.org/jira/browse/HBASE-6846 > Project: HBase > Issue Type: Bug > Components: Filters > Affects Versions: 0.94.1 > Environment: HBase 0.94.1 + Hadoop 2.0.0-cdh4.0.1 > Reporter: Lucian George Iordache > Assignee: Lars Hofhansl > Fix For: 0.94.3, 0.96.0 > > Attachments: 6846-trunk.txt, HBASE-6846.patch > > > The HBase 0.94.1 BitComparator introduced a bug in the method "compareTo": > {code} > @Override > public int compareTo(byte[] value, int offset, int length) { > if (length != this.value.length) { > return 1; > } > int b = 0; > //Iterating backwards is faster because we can quit after one non-zero > byte. > for (int i = value.length - 1; i >= 0 && b == 0; i--) { > switch (bitOperator) { > case AND: > b = (this.value[i] & value[i+offset]) & 0xff; > break; > case OR: > b = (this.value[i] | value[i+offset]) & 0xff; > break; > case XOR: > b = (this.value[i] ^ value[i+offset]) & 0xff; > break; > } > } > return b == 0 ? 1 : 0; > } > {code} > I've encountered this problem when using a BitComparator with a configured > this.value.length=8, and in the HBase table there were KeyValues with > keyValue.getBuffer().length=207911 bytes. In this case: > {code} > for (int i = 207910; i >= 0 && b == 0; i--) { > switch (bitOperator) { > case AND: > b = (this.value[207910] ... ==> ArrayIndexOutOfBoundsException > break; > {code} > That loop should use: > {code} > for (int i = length - 1; i >= 0 && b == 0; i--) { (or this.value.length.) > {code} > Should I provide a patch for correcting the problem? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira