[ https://issues.apache.org/jira/browse/HBASE-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487573#comment-13487573 ]
stack commented on HBASE-6793: ------------------------------ Patch looks great. Nice cleanup. One question, will we be compiling of the examples every time we build now and running the tests? It seems so going by an invocation w/ this patch applied --> we are building an examples artifiact and it is full of code: $ jar -tf hbase-examples/target/hbase-examples-0.95-SNAPSHOT.jar When we built before this change, did we build example code as part of the general build? Do you know Sergey? > Make hbase-examples module > -------------------------- > > Key: HBASE-6793 > URL: https://issues.apache.org/jira/browse/HBASE-6793 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.96.0 > Reporter: Enis Soztutar > Assignee: Sergey Shelukhin > Labels: noob > Attachments: HBASE-6793.patch, HBASE-6793-v2.patch, > HBASE-6793-v3-thrift-0.9.0.patch, HBASE-6793-v4.1-squashed.patch > > > There are some examples under /examples/, which are not compiled as a part of > the build. We can move them to an hbase-examples module. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira