[ https://issues.apache.org/jira/browse/HBASE-6894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488067#comment-13488067 ]
Sergey Shelukhin commented on HBASE-6894: ----------------------------------------- Thanks! > What does this do in the alter help screen? > hbase> alter 't1', 'f1', {NAME => 'f2', IN_MEMORY => true}, 'f3' It's just one of the varied syntax examples - creates two CFs, one with some setting (e.g. in memory). > Did you add the new delete method? Thats nicer. I'd say don't mention the old > method at all in the help: Delete method was already there, as well as the docs for it. > Says change max filesize of family but its for the table? Old doc, fixed. > We have to keep table_att for the below? It's optional, removed. > Do you think CONFIG a good name for the 'dictionary' that can be in > HTableDescriptor and HColumnDescriptor? Would DICT or DICTIONARY or MAP be > better names than CONFIG? For example, in the below: I'd rather not make a breaking change, or make it separately so that it's easier to revert/not take. > I created a table with some table attributes. When I describe it, the METHOD > => 'table_att' is a little confusing I'd say? Do we have to have that METHOD > => 'table_att' in there? Could be a dictionary named 'table_att'? or 'table > _attributes'? Will remove. > I was thinking I could add a new table attribute 'METADATA' doing the > following but fails. Should I be able too? User attributes are only allowed in the specific place separate from system ones to avoid ambiguity/conflicts if we add new system attributes. > Adding metadata to a table in the shell is both arcane and painful > ------------------------------------------------------------------ > > Key: HBASE-6894 > URL: https://issues.apache.org/jira/browse/HBASE-6894 > Project: HBase > Issue Type: Bug > Components: shell > Affects Versions: 0.96.0 > Reporter: stack > Assignee: Sergey Shelukhin > Labels: noob > Attachments: HBASE-6894.patch, HBASE-6894.patch, HBASE-6894.patch, > HBASE-6894-v2.patch, HBASE-6894-v3.1-squashed.patch, > HBASE-6894-v3-squashed.patch > > > In production we have hundreds of tables w/ whack names like 'aliaserv', > 'ashish_bulk', 'age_gender_topics', etc. It be grand if you could look in > master UI and see stuff like owner, eng group responsible, miscellaneous > description, etc. > Now, HTD has support for this; each carries a dictionary. Whats a PITA > though is adding attributes to the dictionary. Here is what seems to work on > trunk (though I do not trust it is doing the right thing): > {code} > hbase> create 'SOME_TABLENAME', {NAME => 'd', VERSION => 1, COMPRESSION => > 'LZO'} > hbase> # Here is how I added metadata > hbase> disable 'SOME_TABLENAME' > hbase> alter 'SOME_TABLENAME', METHOD => 'table_att', OWNER => 'SOMEON', > CONFIG => {'ENVIRONMENT' => 'BLAH BLAH', 'SIZING' => 'The size should be > between 0-10K most of the time with new URLs coming in and getting removed as > they are processed unless the pipeline has fallen behind', 'MISCELLANEOUS' => > 'Holds the list of URLs waiting to be processed in the parked page detection > analyzer in ingestion pipeline.'} > ... > describe... > enable... > {code} > The above doesn't work in 0.94. Complains about the CONFIG, the keyword we > are using for the HTD dictionary. > It works in 0.96 though I'd have to poke around some more to ensure it is > doing the right thing. > But this METHOD => 'table_att' stuff is really ugly.... can we fix it? > And I can't add table attributes on table create seemingly. > A little bit of thought and a bit of ruby could clean this all up. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira