Jimmy Xiang created HBASE-7090:
----------------------------------

             Summary: HMaster#splitLogAndExpireIfOnline actually does it if the 
server is NOT online
                 Key: HBASE-7090
                 URL: https://issues.apache.org/jira/browse/HBASE-7090
             Project: HBase
          Issue Type: Bug
          Components: master, Region Assignment
            Reporter: Jimmy Xiang
            Assignee: Jimmy Xiang
            Priority: Minor


This has been there for some time. It is a surprise to find it is reversed 
actually.  Did I missing anything?

I think it really means to do it if the server is online.

{noformat}
  private void splitLogAndExpireIfOnline(final ServerName sn)
      throws IOException {
    if (sn == null || !serverManager.isServerOnline(sn)) {
      return;
    }
    LOG.info("Forcing splitLog and expire of " + sn);
    fileSystemManager.splitLog(sn);
    serverManager.expireServer(sn);
  }
{noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to