[ 
https://issues.apache.org/jira/browse/HBASE-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502176#comment-13502176
 ] 

Ted Yu commented on HBASE-7202:
-------------------------------

{code}
+   * Remove the store files of the specified region family,
{code}
Better expand 'region family'.
{code}
+   * @param parent Parent region hosting the store files
+   * @param conf {@link Configuration} to examine to determine the archive 
directory
+   * @param familyDir the family dir path hosting the store files
{code}
Order of conf and parent is reverted. There is no familyDir parameter.
{code}
+    if (storeFiles == null) {
+      LOG.debug("No store files to dispose, done!");
{code}
If you keep the above debug log, consider adding region name and family name.
{code}
+          + " into " + storeArchiveDir + "Something is probably arwy on the 
filesystem.");
{code}
nit: add punctuation before the S in Something. Spelling: arwy

                
> Family Store Files are not archived on admin.deleteColumn()
> -----------------------------------------------------------
>
>                 Key: HBASE-7202
>                 URL: https://issues.apache.org/jira/browse/HBASE-7202
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.2, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7202-v1.patch
>
>
> using HBaseAdmin.deleteColumn() the files are not archived but deleted 
> directory.
> This causes problems with snapshots, and other systems that relies on files 
> to be archived.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to