[ 
https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504866#comment-13504866
 ] 

Gregory Chanan commented on HBASE-7215:
---------------------------------------

I think your rant is justified, no need to apologize :).  I removed the 
writable code from Append, Get, RowMutations, and Scan because it was on the 
path of what I was working on (converting Filters), but it looks like we never 
circled back to make sure this was done in all areas.

You mind posting this on review board, Lars?

One thing I noticed scanning the patch is that there are still no-arg 
constructors for Writables that could probably be removed, e.g.
{code}
   /** Constructor for Writable.  DO NOT USE */
   public Delete() {
     this((byte [])null);
{code}


                
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
>                 Key: HBASE-7215
>                 URL: https://issues.apache.org/jira/browse/HBASE-7215
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to