[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505672#comment-13505672 ]
stack commented on HBASE-7120: ------------------------------ In patch, if we fail, I see we echo a message. Should we not also fail the startup if we can't write a pid file? > hbase-daemon.sh (start) missing necessary check when writing pid and log files > ------------------------------------------------------------------------------ > > Key: HBASE-7120 > URL: https://issues.apache.org/jira/browse/HBASE-7120 > Project: HBase > Issue Type: Bug > Affects Versions: 0.94.0 > Environment: RHEL 5.3, open JDK 1.6 > Reporter: Li Ping Zhang > Assignee: Li Ping Zhang > Labels: patch > Attachments: HBASE-7120-0.94.patch, HBASE-7120-trunk.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing > hbase-daemon.sh failed with "start", which doesn’t do required command exit > code check, it's better to do necessary check when writing pid and log files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira