[ https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505678#comment-13505678 ]
stack commented on HBASE-7226: ------------------------------ I'm not sure your patch correct. Could you add a unit test to prove it is? Thank you Feng. > HRegion.checkAndMutate uses incorrect comparison result for <, <=, > and >= > --------------------------------------------------------------------------- > > Key: HBASE-7226 > URL: https://issues.apache.org/jira/browse/HBASE-7226 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.94.2 > Environment: 0.94.2 > Reporter: Feng Honghua > Priority: Minor > Fix For: 0.94.2 > > Attachments: HRegion_HBASE_7226_0.94.2.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > in HRegion.checkAndMutate, incorrect comparison results are used for <, <=, > > and >=, as below: > switch (compareOp) { > case LESS: > matches = compareResult <= 0; // should be '<' here > break; > case LESS_OR_EQUAL: > matches = compareResult < 0; // should be '<=' here > break; > case EQUAL: > matches = compareResult == 0; > break; > case NOT_EQUAL: > matches = compareResult != 0; > break; > case GREATER_OR_EQUAL: > matches = compareResult > 0; // should be '>=' here > break; > case GREATER: > matches = compareResult >= 0; // should be '>' here > break; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira