[
https://issues.apache.org/jira/browse/HBASE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527016#comment-13527016
]
Ted Yu commented on HBASE-7205:
-------------------------------
Thanks for following up, Adrian.
{code}
+ regionsActiveClassLoaders.put(region,
region.getCoprocessorHost().activeCoprocessorClassLoaders);
...
+ Set<ClassLoader> allClassLoaders = new
HashSet<ClassLoader>(CoprocessorHost.classLoadersCache.values());
...
+ assertEquals("CP Classloader for region " + regionCP.getKey() + " is
not cached", allClassLoaders, regionCP.getValue());
{code}
Above lines are beyond 100 characters.
{code}
+ assertTrue("No region has found for table " + tableName, foundTableRegion);
{code}
'has found' -> 'was found'
Looks like clearCacheForTesting() can be replaced with calling
classLoadersCache.clear() directly.
getClassloaderCountForTesting() can be removed since you added more assertions.
> Coprocessor classloader is replicated for all regions in the HRegionServer
> --------------------------------------------------------------------------
>
> Key: HBASE-7205
> URL: https://issues.apache.org/jira/browse/HBASE-7205
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Adrian Muraru
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.96.0, 0.94.4
>
> Attachments: 7205-v1.txt, 7205-v3.txt, 7205-v4.txt, 7205-v5.txt,
> HBASE-7205_v2.patch
>
>
> HBASE-6308 introduced a new custom CoprocessorClassLoader to load the
> coprocessor classes and a new instance of this CL is created for each single
> HRegion opened. This leads to OOME-PermGen when the number of regions go
> above hundres / region server.
> Having the table coprocessor jailed in a separate classloader is good however
> we should create only one for all regions of a table in each HRS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
