[ 
https://issues.apache.org/jira/browse/HBASE-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528362#comment-13528362
 ] 

Sergey Shelukhin commented on HBASE-7243:
-----------------------------------------

Is 10 minutes an appropriate time for the minicluster? Seems like it should be 
much less. On real cluster the person executing the test would probably set the 
value appropriately.

Why does the test need 2 region servers by default?

Nit: not sure what the casing convention is, but fields like 
REGION_SERVER_COUNT appear to be constants when they aren't.

{code}
    util.initializeCluster(REGION_SERVER_COUNT);
      LOG.info("Cluster initialized");
{code}
Some spacing issues.

{code}
private HBaseAdmin admin;
{code}
final?

{code}
         LOG.info(String.format("Pre-split table created successfully in 
%sms.", (endTime - startTime)));
{code}
Not sure if it matters in Java... %s format for a long.

                
> Test for creating a large number of regions
> -------------------------------------------
>
>                 Key: HBASE-7243
>                 URL: https://issues.apache.org/jira/browse/HBASE-7243
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment, regionserver, test
>            Reporter: Enis Soztutar
>            Assignee: Nick Dimiduk
>              Labels: noob
>             Fix For: 0.96.0
>
>         Attachments: 7243-integration-test-many-splits.diff
>
>
> After HBASE-7220, I think it will be good to write a unit test/IT to create a 
> large number of regions. We can put a reasonable timeout to the test. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to