[ https://issues.apache.org/jira/browse/HBASE-7323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528795#comment-13528795 ]
Ted Yu commented on HBASE-7323: ------------------------------- Where would the following methods be used ? {code} +// @Override + public Cell getCurrentCell(){ + return current; + } + +// @Override + public boolean nextCell(){ + return next(); + } {code} For getCurrentCell(), I only found it mentioned in the javadoc of CellScannerPosition.java Can you tell us more about your benchmark ? > add Cell interface to SeekerState and BufferedEncodedSeeker > ----------------------------------------------------------- > > Key: HBASE-7323 > URL: https://issues.apache.org/jira/browse/HBASE-7323 > Project: HBase > Issue Type: Sub-task > Components: Compaction, Performance, regionserver, Scanners > Affects Versions: 0.96.0 > Reporter: Matt Corgan > Attachments: HBASE-7323-SeekerState-Cell-v1.patch > > > SeekerState is the staging site for a Cell while it is being assembled by the > BufferedEncodedSeeker. When the parent StoreFileScanner calls > getCurrentCell() it's guaranteed that the Cell is fully assembled, and we can > directly return the SeekerState as a Cell rather than copying it into a > KeyValue. A benchmark at the StoreFileScanner level show ~50% faster > cells/sec than when copying to KeyValues (ignoring garbage collection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira