[ https://issues.apache.org/jira/browse/HBASE-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531602#comment-13531602 ]
Hudson commented on HBASE-7340: ------------------------------- Integrated in HBase-TRUNK #3619 (See [https://builds.apache.org/job/HBase-TRUNK/3619/]) HBASE-7340 Master coprocessor notification for assignmentManager.balance() is inconsistent (Ted Yu) (Revision 1421537) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlan.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java > Master coprocessor notification for assignmentManager.balance() is > inconsistent > ------------------------------------------------------------------------------- > > Key: HBASE-7340 > URL: https://issues.apache.org/jira/browse/HBASE-7340 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Trivial > Fix For: 0.96.0 > > Attachments: 7340-v1.txt, 7340-v2.txt > > > I found this issue when reading user discussion which is quoted below. > In HMaster.moveRegion(), we have: > {code} > this.assignmentManager.balance(rp); > if (this.cpHost != null) { > this.cpHost.postMove(hri, rp.getSource(), rp.getDestination()); > } > {code} > Meaning, user can register master coprocessor which would receive region > movement notification. > The assignmentManager.balance(plan) call in HMaster.balance() doesn't send > out such notification. > I think we should enhance the following hook (at line 1335) with list of > regions moved so that notification from master is consistent: > {code} > this.cpHost.postBalance(); > {code} > Here is excerpt for user discussion: > Sometimes user performs compaction after a region is moved (by balancer). We > should provide 'hook' which lets user specify what follow-on actions to take > after region movement. > See discussion on user mailing list under the thread 'How to know it's time > for a major compaction?' for background information: > http://search-hadoop.com/m/BDx4S1jMjF92&subj=How+to+know+it+s+time+for+a+major+compaction+ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira