[ 
https://issues.apache.org/jira/browse/HBASE-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534451#comment-13534451
 ] 

stack commented on HBASE-4791:
------------------------------

The two tests pass for me locally.

Calling the below with a null from MasterCommandLine will give us what 
[~mbertozzi]?

+    String principalName = SecurityUtil.getServerPrincipal(principalConfig, 
hostname);

Also, will it be a problem if we call the below in the regionserver constructor:

+    ZKUtil.loginClient(this.conf, "hbase.zookeeper.client.keytab.file",
+      "hbase.zookeeper.client.kerberos.principal", this.isa.getHostName());

... and then, for whatever reason, after we report for duty to the master, it 
tells us use another name... See the code in handleReportForDutyResponse around 
#1156?

Maybe the  name the regionserver uses talking to the master is unrelated to 
that used here when we are registering a principal?

FYI, you need curly braces even if only one line follows the if clause ... i.e. 
the tests you do in login where you follow them by a single line w/ 'return' on 
it.  I can fix these on commit np.
                
> Allow Secure Zookeeper JAAS configuration to be programmatically set (rather 
> than only by reading JAAS configuration file)
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4791
>                 URL: https://issues.apache.org/jira/browse/HBASE-4791
>             Project: HBase
>          Issue Type: Improvement
>          Components: security, Zookeeper
>            Reporter: Eugene Koontz
>            Assignee: Matteo Bertozzi
>              Labels: security, zookeeper
>         Attachments: DemoConfig.java, HBASE-4791-v1.patch, 
> HBASE-4791-v2.patch, HBASE-4791-v3.patch, HBASE-4791-v4-0.94.patch, 
> HBASE-4791-v4.patch, HBASE-4791-v4.patch
>
>
> In the currently proposed fix for HBASE-2418, there must be a JAAS file 
> specified in     System.setProperty("java.security.auth.login.config"). 
> However, it might be preferable to construct a JAAS configuration 
> programmatically, as is done with secure Hadoop (see 
> https://github.com/apache/hadoop-common/blob/a48eceb62c9b5c1a5d71ee2945d9eea2ed62527b/src/java/org/apache/hadoop/security/UserGroupInformation.java#L175).
> This would have the benefit of avoiding a usage of a system property setting, 
> and allow instead an HBase-local configuration setting. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to