[ 
https://issues.apache.org/jira/browse/HBASE-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536812#comment-13536812
 ] 

stack commented on HBASE-5448:
------------------------------

Thanks for fixing the null issue G.

A thought.  I think this pb-based way of doing dynamic cps elegant after 
looking at it a while.  I know 'elegant' is not the first thing that comes to 
mind when you have pb and rpc in the mix, but hey, can't keep it to myself.

One thing I think we have lost though going to this new mechanism is the 
ability to do generics: i.e. GenericProtocol over in hbase-server/src/test 
can't be made work now.  I believe this so because pb requires you specify a 
type: https://developers.google.com/protocol-buffers/docs/proto#simple  Do you 
agree G?

I think this fine.  We just need to doc. it in ref notes above I'd say and be 
done w/ it.
                
> Support for dynamic coprocessor endpoints with PB-based RPC
> -----------------------------------------------------------
>
>                 Key: HBASE-5448
>                 URL: https://issues.apache.org/jira/browse/HBASE-5448
>             Project: HBase
>          Issue Type: Sub-task
>          Components: IPC/RPC, master, migration, regionserver
>            Reporter: Todd Lipcon
>            Assignee: Gary Helmling
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5448_2.patch, HBASE-5448_3.patch, 
> HBASE-5448_4.patch, HBASE-5448.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to