[ https://issues.apache.org/jira/browse/HBASE-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540777#comment-13540777 ]
chunhui shen commented on HBASE-7299: ------------------------------------- {code} + UTIL.waitTableAvailable(Bytes.toBytes(TEST_TABLE), 15 * 1000); {code} Yes, test will be failed if table is not available after 15 seconds, is 15 seconds eough? bq.why we waiting for no regions being online before we'll abort? Not before we'll abort, waiting for no regions being online after we abort the server. It is because: We send the abort request, but the regionserver still serves regions for some time, so the next keys may be put to the abort server successfully. Also the thread may be live when we doing the assert for count of live servers, causing test failed If we waiting for no regions being online after we abort the server, we could ensure the master has re-assigned the regions on killed server after putting keys successfully, it means the server we abort is dead and detected by matser > TestMultiParallel fails intermittently in trunk builds > ------------------------------------------------------ > > Key: HBASE-7299 > URL: https://issues.apache.org/jira/browse/HBASE-7299 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7299.patch > > > From trunk build #3598: > {code} > testFlushCommitsNoAbort(org.apache.hadoop.hbase.client.TestMultiParallel): > Count of regions=8 > {code} > It failed in 3595 as well: > {code} > java.lang.AssertionError: Server count=2, abort=true expected:<1> but was:<2> > at org.junit.Assert.fail(Assert.java:93) > at org.junit.Assert.failNotEquals(Assert.java:647) > at org.junit.Assert.assertEquals(Assert.java:128) > at org.junit.Assert.assertEquals(Assert.java:472) > at > org.apache.hadoop.hbase.client.TestMultiParallel.doTestFlushCommits(TestMultiParallel.java:267) > at > org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsWithAbort(TestMultiParallel.java:226) > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira