[ https://issues.apache.org/jira/browse/HBASE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549948#comment-13549948 ]
Sergey Shelukhin commented on HBASE-7531: ----------------------------------------- +1. The cause is the dubious semantics of openReader imho (but I may just be unfamiliar with code); sleepMultiplier decision can be in the outside loop and openReader return value meaning can then be simpler. > [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't > nullify the reader > ----------------------------------------------------------------------------------------------- > > Key: HBASE-7531 > URL: https://issues.apache.org/jira/browse/HBASE-7531 > Project: HBase > Issue Type: Bug > Reporter: Jean-Daniel Cryans > Assignee: Jean-Daniel Cryans > Attachments: HBASE-7531.patch > > > Here's a NPE I get half the time I run TestReplication: > {noformat} > 2012-12-20 08:59:17,259 ERROR > [RegionServer:1;192.168.10.135,49168,1356011734418-EventThread.replicationSource,2] > regionserver.ReplicationSource$1(727): Unexpected exception in > ReplicationSource, > currentPath=hdfs://localhost:65533/user/jdcryans/hbase/.logs/192.168.10.135,49168,1356011734418/192.168.10.135%2C49168%2C1356011734418.1356011956626 > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.seek(SequenceFileLogReader.java:261) > at > org.apache.hadoop.hbase.replication.regionserver.ReplicationHLogReaderManager.seek(ReplicationHLogReaderManager.java:103) > at > org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.readAllEntriesToReplicateOrNextFile(ReplicationSource.java:414) > at > org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:332) > {noformat} > The issue happens after an IOE was caught while opening the reader, the issue > is that it isn't set to null after that then the rest of the code assumes the > reader is usable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira