[ https://issues.apache.org/jira/browse/HBASE-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550672#comment-13550672 ]
Hadoop QA commented on HBASE-7365: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564298/HBASE-7365-v2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationWithCompression Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3969//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3969//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3969//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3969//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3969//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3969//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3969//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3969//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3969//console This message is automatically generated. > Safer table creation and deletion using .tmp dir > ------------------------------------------------ > > Key: HBASE-7365 > URL: https://issues.apache.org/jira/browse/HBASE-7365 > Project: HBase > Issue Type: Improvement > Components: master > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Fix For: 0.96.0 > > Attachments: HBASE-7365-v0.patch, HBASE-7365-v1.patch, > HBASE-7365-v2.patch > > > Currently tables are created in the root directory, and the removal works on > the root directory. > Change the code to use a /hbase/.tmp directory to make the creation and > removal a bit safer > Table Creation steps > * Create the table descriptor (table folder, in /hbase/.tmp/) > * Create the table regions (always in temp) > * Move the table from temp to the root folder > * Add the regions to meta > * Trigger assignment > * Set enable flag in ZooKeeper > Table Deletion steps > * Wait for regions in transition > * Remove regions from meta (use bulk delete) > * Move the table in /hbase/.tmp > * Remove the table from the descriptor cache > * Remove table from zookeeper > * Archive the table > The main changes in the current code are: > * Writing to /hbase/.tmp and then rename > * using bulk delete in DeletionTableHandler -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira